Enable Coretime Integration Tests & Update Changelog for SetTopic Changes#759
Conversation
|
Review required! Latest push from author must always be reviewed |
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
Please see the comment: https://github.com/polkadot-fellows/runtimes/pull/759/files#r2135462984
raymondkfcheung
changed the title
raymondkfcheung
changed the title
raymondkfcheung
changed the title
raymondkfcheung
changed the title
SetTopic Changes
|
@raymondkfcheung please check the failing test(s) |
It's due to #754. I'm searching the root causes and will fix it. |
| pub const MinimumCreditPurchase: Balance = UNITS / 10; | ||
|
|
||
| pub const MinimumEndPrice: Balance = UNITS; | ||
| pub const MinimumEndPrice: Balance = UNITS / 100_000; |
There was a problem hiding this comment.
| pub const MinimumEndPrice: Balance = UNITS / 100_000; | |
| pub const MinimumEndPrice: Balance = UNITS; |
| pub const BrokerPalletId: PalletId = PalletId(*b"py/broke"); | ||
| pub const MinimumCreditPurchase: Balance = UNITS / 10; | ||
| pub const MinimumEndPrice: Balance = 10 * UNITS; | ||
| pub const MinimumEndPrice: Balance = UNITS / 10_000; |
There was a problem hiding this comment.
| pub const MinimumEndPrice: Balance = UNITS / 10_000; | |
| pub const MinimumEndPrice: Balance = 10 * UNITS; |
There was a problem hiding this comment.
I'll push these changes and the tests fix to a branch and make a PR
There was a problem hiding this comment.
@seadanda updated the tests according to #759 (review)
This reverts commit 034429b.
seadanda
left a comment
seadanda
left a comment
There was a problem hiding this comment.
Kind of magic numbers in the test which we can easily improve.
The point where start_sales is called has an argument which is the start price. Currently it starts with ed, but if this is below the minimum price it will just use the minimum price.
If you start sales at start_sales(RuntimeOrigin::root(), UNITS, 1)
Then mint 200 * UNITS and purchase using 100 * UNITS the numbers in the test will be self-consistent
|
/merge |
fellowship-merge-bot
bot
merged commit 1668c86
into
polkadot-fellows:main
|
Enabled Available commands
For more information see the documentation |
6 participants
This PR does two things:
CHANGELOG.mdto reflect the inclusion ofSetTopic-related changes from Polkadot SDKstable2503-5.This partially addresses paritytech/polkadot-sdk#6119 and continues the work from paritytech/polkadot-sdk#7691.